Overview - Code Review and Code Quality Issue - 001

Let’s begin the journey to write better and bug free code. This series would focus on optimization and quality of code in java.

How we can simplify below code snippet

 /**
  * Here, Payment Indicator means if you are doing online 
  * shopping or with Point of Sale at Shop. And, 1 corresponds
  *  to online shopping and 0 corresponds by Point of Sale. 
  *  Additionally, by default it should 0 i.e Point of Sale.
  */
private int getPaymentIndicator(Boolean value) {
    if (value == null) {
        return 0;
    } else if (value.booleanValue()) {
        return 1;
    } else {
        return 0;
    }
}

Refactoring : 1

• Add final to the method parameter
• Method can be static
• Last else block is not required.
• Second, else if can be changed to if.

private static int getPaymentIndicatorRefactoringOne(final Boolean value) {
    if (value == null) {
        return 0;
    }
    if (value.booleanValue()) {
        return 1;
    }
    return 0;
}

Refactoring : 2

Possible values of Boolean can be Boolean.True , Boolean.FALSE and NULL.

In this particular case, we can further simplify the method by understanding the mapping of possible values.

• NULL and BOOLEAN.FALSE are mapped to 0
• BOOLEAN.TRUE is mapped to 1

private static int getPaymentIndicatorRefactoringTwo(final Boolean value) {
    return Boolean.TRUE.equals(value) ? 1 : 0;
}

We can also write return Boolean.FALSE.equals(value) ? 0 : 1; Usually, FALSE, NULL, NOT EQUAL these are negative words, and It’s good to use positive words, it brings good vibes while coding.

And, Bang we have reduced the 9 lines of code to just 3 lines.

By Pratiyush Kumar Singh

Next Post: Coming Soon - Spotless: Keep your code spotless